P
Matt Pahuta• 540
@MattPahuta
Posted
- Nice use of flexbox and Grid to match the design comp
- Good use of semantic elements here (form, ul, etc.)
- The JavaScript looks great
- Media queries should be set in rem/em, not px. Here's a good resource
- I'd consider putting this image in the HTML. Background images are less performant and it's bad practice to have empty divs/elements in the HTML. This particular image is a good use case for the picture element
- Also with the image: use max-widths instead of hard-coded widths. You shouldn't need to set a specific height property for anything in this challenge either. In general, setting heights like this should be avoided.
- The email on the confirmation page is not being dynamically applied. You've got solid JavaScript code already, it should be straightforward for you to drop an ID on that span and populate the email received via the form.
- The cursor for button hover states should be a pointer
- All in all, very nice work. Cheers!
Marked as helpful
0
