Design comparison
Solution retrospective
This is the second time I finished this challenge and I wrote my JS way different this time, and added a new feature to it(automatic error state remover). So I suppose that I could redo this challenge every so often as my JS skills improve and all the time the solution would be different to a degree.
What challenges did you encounter, and how did you overcome them?I faced different kind of challenges all that I would overcome by researching topics or watching videos. The biggest problem I faced and didn't manage to overcome was the fact that I wanted to store the current state of the html in a variable which sort of worked but it didn't store the CSS itself for some reason. But this is something I will do my best to learn for the next challenges that are coming up.
What specific areas of your project would you like help with?Just general code review for my JS code and how I styled the page with CSS. I still have a ton to learn from my mistakes.
Community feedback
- @ijohnstPosted 5 months ago
First of all great work!
One thing that might help is to use the
<picture>
element to swap from the desktop to mobile image on mobile screen sizes (right now in mobile view you have the desktop.svg showing). This worked for me:<picture class="signup--image"><source srcset="./assets/images/illustration-sign-up-desktop.svg" media="(min-width: 55em)"><img src="./assets/images/illustration-sign-up-mobile.svg" alt="Illustration of a website dashboard and tablet"></picture>
Just make sure the media attribute in there matches whatever breakpoint you are using for your media queries
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord