Design comparison
Solution retrospective
Hi there 👋, This is my solution for this challenge.
📑 Features:-
- Achieved 100% score for Accessibility, SEO & Best Practices and 98% score for Performance in Desktop Lighthouse. 📊
- Achieved 100% score for Accessibility, Best Practices and 96% score for Performance in Mobile Lighthouse. 📊
- Code implemented using BEM Methodology 💻
- If else statement, addEventListener( ), Email Validation 📝
- DOM 📝 -classList.add/remove( ) 📝
- Simple Transition background-color while hovering on button. 🎬
- Clamp( ) method for responsive design ( changing according to viewport dimensions and suiting with different layout devices ). 💻 📱
- FlexBox 📦
- Image changes relative to the viewport width (@media) by using Picture tag ✨
- Code formatted using Prettier 💻
I'll appreciate any suggestions & feedback to achieve better performance.
Thank you. ✌️
Community feedback
- @crsimpson5Posted 11 months ago
Hey Kimo,
Nice job on your solution. It looks great for desktop viewports. I like the button hover effect too.
The main problem is that it doesn't work for small viewports. With your clamp functions your font size is getting down to 7px -- way too small. Try testing it out on your phone and tablet if you have one.
Also, you don't need widths on every element. Elements should resize based on their container's width. Here's a resource that may help out: Be The Browser’s Mentor, Not Its Micromanager.
2@kimodev1990Posted 11 months ago@crsimpson5 Thank you for your feedback,
- I could've added the sizes but the desired mobile design in readme file starts from 375px.
- As for widths, I'll try to use container queries next time
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord