Newsletter Signup Form built with BEM, SASS/SCSS, JavaScript and Vite.

Community feedback

• 

  Alok Suman•2,380

  @Alokray007Posted 9 months ago

  Hello there 👋

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope this suggestion is useful for future projects.

  Other than that, great job!

  Happy coding.

  1

  ---

  

  Johnny•470

  @johnnysedh3llloPosted 9 months ago

  Thank for the feedback @Alokray007.

  In regards to the Chrome Extension "Perfect Pixel" that's actually what i used to work on this project but maybe i need to get better at using it.

  I appreciate the comment you made on Semantics. Please what tag would you suggest i use in that use case instead of a div or span?

  0

  

  Alok Suman•2,380

  @Alokray007Posted 9 months ago

  @johnnysedh3lllo You can use Semantic HTML elements like main, section, article etc.

  1

  

  Johnny•470

  @johnnysedh3llloPosted 9 months ago

  thanks for the feedback @Alokray007, i appreciate.

  0