Newsletter sign-up form

Community feedback

• 

  ezecoder•870

  @3eze3Posted over 1 year ago

  Hello Antoine Estievenart, good solution for this challenge.

  I have two corrections that can be made to your project.

  Js:

  I see that in the validation of the email, you use the regex: (/^^\w+([.-]?\w+)@@\w+([.-]?\w+)(\w{2,3})+$/) does not really check the domain structure after the "@" and allows any unrestricted word to be valid. For example: [email protected]". You could simplify it to correct the validation error like this: /^\w+([.-]?\w+)@@[a-zA-Z0-9]+([.-]?[a-zA-Z0-9]+)(\w{2,})+$/;

  Html:

  • As for the images with decoration, it doesn't really have a semantic meaning, so it would be best to use an ari-hidden="True". <img src="./assets/images/icon-list.svg" alt="icon">

  <img src="./assets/images/icon-success.svg" alt="icon success"> Html:

  Marked as helpful

  1
• 

  Joy•30

  @JOY2OPPosted 12 months ago

  You should do:

  .subscription-btn{ border: none; outline: none; }

  For more accurate look

  0