Skip to content
Submitted over 1 year ago

Newsletter signup challenge, made with React Sass and TypeScript.

Carlos Teixeira•30
@scarlosteixeira
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Newsletter sign-up form with success message
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

I'd like to heard from you any comments about best pratices and improvements that I should apply on my code.

Community feedback

  • Darkstar•1,100
    @DarkstarXDDPosted 17 days ago

    As part of the learning paths, i was asked to give some feedback on your solution. Couple of suggestions i have.

    • You can switch to the desktop layout bit more earlier, so mid size screens won't see lot of empty space.
    • Currently the error message is displayed as soon as i type the first letter in the input. I think it's a bit annoying. You should allow the user to try and submit at least one invalid entry first, before showing any errors. The ideal option would be to validate onblur.
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord