Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Newsletter Signup by Sham

Sham Sunderβ€’ 240

@ShamSuther

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please take a moment to review the component I have created using HTML, CSS, JavaScript, and Animate.css. I would greatly appreciate it if you could rate it on a scale of 1 to 10 and provide any feedback you may have for future enhancements.

Community feedback

Tushar Biswasβ€’ 4,080

@itush

Posted

Congratulations on completing the challenge! πŸŽ‰

Your solution looks very beautiful :)

My rating: 8/10

In my projects:

  • I always start with mobile-first workflow.
  • I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.
<body>
<main>
All content 
</main>
</body>
  • I Use relative units as much as possible and avoid absolute units whenever possible.

  • If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project. Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals, make few projects only with the trio and then move on to any framework or library.

  • I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! πŸ™Œ To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:

πŸ“šπŸ” 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.

πŸ“šπŸ” 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements.

I hope you find these resources somewhat helpful in your coding adventures! 🀞

I'm eagerly looking forward to seeing the amazing projects you'll create in the future! πŸš€πŸ’»

Keep up the fantastic work and happy hacking! πŸ’ͺ✨

Marked as helpful

1

Sham Sunderβ€’ 240

@ShamSuther

Posted

@itush Thank you for your response. I found it to be quite insightful. I intend to peruse your article and recommendations, as well as review additional articles. Happy hacking to you as well 😊 πŸš€πŸ’»βœ¨.

1
Tushar Biswasβ€’ 4,080

@itush

Posted

@ShamSuther

You are most welcome!

Your solution is indeed amazing :)

If you are interested, let's connect on twitter and stay in touch.

We all get better with practice, you got this πŸ’ͺ

Always happy to help😁

BTW: It would motivate me to provide quality support like this to the community, if you could spare a moment and give my GitHub pinned projects a ⭐️ star.

Marked as helpful

1
Rinoβ€’ 340

@Rhinozer0s

Posted

Hey, i also have some suggestions for improvement for you.πŸ™ƒ

Espacially for responsive images, there is the <picture> element. The code for it could look like this:

<picture>
<source media="(min-width:40em)" srcset="image-desktop"> // media query
<img src="image-mobile"> // fall-back image
</picture>

You can read more about the picture-tag here

What has always bothered me a lot is the little white border under the image. You can fix this by assigning the display: block; property to the image.

i hope you find this helpful mate 🀝

Marked as helpful

0

Sham Sunderβ€’ 240

@ShamSuther

Posted

@Rhinozer0s Thanks mate really appreciate the feedback 😊🀝

0
moonrose93β€’ 370

@moonrose93

Posted

looking cool ! but I need some help heere. why when I upoad the file via github in the netlify platform the svgs are not shown in the preview? Im new in this so pls some tip, do I need to convert the svg files into HTML code? hmm

1

Tushar Biswasβ€’ 4,080

@itush

Posted

@moonrose93

In my solution I just linked the svgs in the HTML and it works. Feel free to go through my solution to get some ideas.

0
Sham Sunderβ€’ 240

@ShamSuther

Posted

@moonrose93 You can use .svg files as you use image files but make sure to give them width and height ( you can set the height to auto after setting a width ) in CSS.

1
moonrose93β€’ 370

@moonrose93

Posted

@itush thanks i had an issue but i fixed it :D

Marked as helpful

1
Sham Sunderβ€’ 240

@ShamSuther

Posted

@moonrose93 Good to know, keep up the good work πŸ˜ŠπŸ’» ✨.

0
moonrose93β€’ 370

@moonrose93

Posted

@ShamSuther THANK YOU just fixed the issue. i would like to receive a feedback on my project if you dont mind

0
moonrose93β€’ 370

@moonrose93

Posted

@ShamSuther THANK YOU just fixed the issue. i would like to receive a feedback on my project if you dont mind

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord