Design comparison
Solution retrospective
I'm pleased with the outcome, and how close it it is to the design.
What challenges did you encounter, and how did you overcome them?Setting a background color on the input field seems to place the background over the placeholder text. Had to make background color somewhat transparent instead.
When adding the error class to my input field based on validation outcome, the field still inherited border color so I had to use !important, which I would prefer not to do.
.error {
border-color: var(--tomato) !important;
background-color: var(--tomato-transparent);
color: var(--tomato);
&:active, &:focus, &:target {
border: 1.5px solid var(--dark-slate-grey) !important;
}
&::placeholder {
color: var(--tomato);
opacity: 1;
}
}
What specific areas of your project would you like help with?
Any feedback is appreciated 😁
I added "autocomplete="email" autofocus" to my input field and I am not sure if this is bad practice, both for security reasons and for accessibility.
Secondly, whenever you type in an invalid email and try to submit, the button state gets "stuck" as active or focused, and I dont know how to prevent this.
Community feedback
- @dolapobjPosted 6 months ago
Hi Maximilian. Thank you for your solution -- it looks great! Actually, looking through your code, is really inspiring me as someone who is just getting started in front-end dev. You also have a great eye for following the designs, which makes me want to follow them more precisely for my next project.
Specifically, I like how you:
- used the aside HTML tag for the success element
- separated your Sass styling by color, typography,
- used the destyle stylesheet for a clean reset
I couldn't follow all the Sass notation as it seems quite, intricate, but your code is clearly commented and easy to follow. Your semantic HTML was also cleaner than mine -- I realize I had redundant containers. I will try to emulate your approach going forward.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord