Submitted 11 months ago
newsletter sign up-with success message
@Abraham-s-yakubu
Design comparison
SolutionDesign
Solution retrospective
I appreciate any feedback you may have and thank you in advance for your input
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width to make sure that the component will have a maximum width on any device, also remove the
width
property with a percentage value or vw.
- Avoid using vh for height, especially on small screens, as it can lead to content overflow. Test by zooming in to observe this behavior. Let the content determine the height or use min-height to allow the component to resize on any screen.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 - Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width to make sure that the component will have a maximum width on any device, also remove the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord