Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

newsletter-sign-up-with-success-message-main with css flex

@AinaKhanDurrani

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

P

@medic-code

Posted

Hi @AinaKhanDurrani

Here's some feedback

General feedback Pretty good job at this, the html, css and js are structured well generally and the user experience is nice. There are a few minor aspects to the UX and UI from the designs to take into account.

Specific Feedback

HTML

  1. Use <main>, <article>/<section> tag elements for more semantic HTML. In just a small component it may seem a little odd to do this though, certainly feels that way to me when I do these challenges.
  2. Consider using a methodology like BEM for the class names, they're a little non-descript as they are currently.
  3. Instead of using CSS to change the desktop image, you can use the <picture> element instead with a media query.

CSS

  1. Decent setup and use of variables
  2. Throughout the css you used very specific % for width which probably reflects the need to use max-width in addition to width%.
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord