Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

newsletter-sign-up-with-success-message-main

P

@wolf2lyon

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

@saularanguren

Posted

Greetings friend, your solution is really amazing, however, we can improve it.

Let's start by removing from the online repository, which is on GitHub, the folders: docs, .vscode and node_modules, these folders should not be in the remote repository, node_modules are dependencies that each programmer downloads if necessary to view, develop, edit the project, they are not necessary and it is even bad practice to have them in the GitHub repository.

.vscode is a folder that stores extensions that the programmer needs to download just for that project, this folder as well as node_modules, should only be in the local repository (the repository that you have on your machine and which you are editing), these two folders you will have in your local repository if they are really necessary.

docs is the folder to store the project documentation, it is usually seen in large projects, I don't see it necessary to have it, however, if you want to have it, it should have the project images, functionalities, uses and so on, but if you are doing a small project, the README.md is more than enough.

I recommend you add these lines of code to all your projects, inside the .gitignore file:

node_modules/
.vscode/

Last but not least, the server.js file, I understand what you want to do, but for this I recommend you create a project with vite.js, astro or another technology, an example would be:

npm create vite@latest
npm create astro@latest

You choose which technology to create the project with: React, Vite, Vanilla JS, but don't complicate things when creating a project, happy coding 😁

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord