Newsletter sign up with success message (added a few changes).
Design comparison
Solution retrospective
Liked the challenge and added a few changes, when the e-mail is valid the input become green, I put the error message on the bottom and not on the top as the design indicated.
What challenges did you encounter, and how did you overcome them?I actually wanted to make 2 html documents, one for the e-mail, the other for the message.
I'd to research how to do it using JS and found about window.location.href
on MDN.
Would like some tips.
Community feedback
- @itsmesrishtiPosted 2 months ago
Hi,
Great work on the project and I like how you added the additional functionality of checking for .com and .org! Also linking the two html files thing looks cool as well.. I'd have to check it out in more detail. Thank you for teaching me a new way of doing things!
Here are a few tips you might want to consider for your next project:
a) Consider using variable names like primary, secondary or bg-color, heading-color as the specific color if changes then the variable name would still be valid.
b) Consider using rem values for the media queries as well. It's considered a good practise. like @media screen and (min-width: 64rem) {}
Again, great work on the project and kudos for adding additional functionality! Onwards and upwards!
0@mts-mlPosted about 2 months agoHey @itsmesrishti
Thanks for the feedback!
Really appreciate it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord