Design comparison
Solution retrospective
š Hello everyone!
šØš»āš» I just completed my next Frontend Mentor task - Newsletter Sign Up with Success Message today! I am open to any suggestions and corrections.
ā My questions regarding this project: š Could I make it like in the design? š Is my code efficient and reusable? š Is it fully responsive and bugless?
š I used ReactJs, CSS, and Tailwind CSS in this project.
š«¶ Thank you!
Community feedback
- @ChamuMutezvaPosted about 1 year ago
Hi Valeh Ismayilov
Nice work so far. Your solution looks great. One thing that I noted is the validation which fails when I submit the form without touching the input field. Making it like the design is a good idea but others also like to make further improvements according to their liking or feature that they are interested in. The background color is the dark when the screen gets larger but you have maintained it as the light color for all dimensions.
Marked as helpful0@vlhsmylvPosted about 1 year ago@ChamuMutezva Oh thank you for reminding me. Unobserved. I will solve it ASAP.
0@vlhsmylvPosted about 1 year ago@ChamuMutezva I checked all the things you mentioned.
Submit the form without touching the input field
It actually cannot submit if the field's value is equal to 0. In this situation, it's 0, so it won't submit. I checked it. I don't know why it works like this on your device. In any case, I checked it on several devices (Mac, Windows, Android, IOS), but I got the negative answer to your problem, so it actually works.
Background colour
The background colour in the larger dimension is bg-gray-100, but the container colour is bg-white, so actually they are different colours. In any case, I made it bg-dark-slate-gray: image
0@ChamuMutezvaPosted about 1 year ago@vlhsmylv ,
It actually cannot submit if the field's value is equal to 0- I was expecting the error message to show but on this occasion it doesn't show anything and yes the error message only shows upon touching the input field0@vlhsmylvPosted about 1 year ago@ChamuMutezva I got your point. I am going to solve it.
0@vlhsmylvPosted about 1 year ago@ChamuMutezva solved the issue! Thank you for contribution!
1@ChamuMutezvaPosted about 1 year ago@vlhsmylv, yes that's exactly what I meant. Well done and happy coding
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord