Newsletter sign up with success message

Community feedback

• 

  Christian G•920

  @cristianccggPosted 11 months ago

  Works perfectly, good job! A minor detail would be to make the button the same height as the input, the rest is perfect.

  Marked as helpful

  1

  ---

  

  Yash Babani•1,260

  @Yashbabani0Posted 11 months ago

  @cristianccgg thanks

  0
• 

  Abdul Khaliq 🚀•72,360

  @0xabdulkhaliqPosted 11 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  LABELS 🔖:

  • input elements wants a label associated with it, currently there's no label element associated with input instead you used b element which will cause accessibility issues.

  ---

  • A <label> is used to create a caption for a form control. The <label> can be associated with a form control either implicitly by placing the control element inside the label element, or explicitly by using the for attribute

  ---

  • Effective form labels are required to make forms accessible. The purpose of form elements such as checkboxes, radio buttons, input fields, etc, is often apparent to sighted users

  ---

  • Even if the form element is not programmatically labeled. Screen readers users require useful form labels to identify form fields.

  ---

  • Example:

  <form>
    <label for="email">Email address</label>
    <input type="email" name="email" id="email" placeholder="email@company.com">
      
    <button type="submit">
         Subscribe to monthly newsletter
    </button>
  </form>
  

  ---

  • If you have any questions or need further clarification, you can always check out my submission for this challenge and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  2