newsletter-sign-up-with-success

Community feedback

• 

  pablodev•430

  @PabloodevPosted 4 months ago

  Whats up @Hexerse?

  Congratulation for your sulution...Its pretty good!

  I'll try to give you some tips that might help you.

  • if you removed the attribution from your code, it would be nice to remove the script tag from the top of your HTML, I was a little confused when I entered kkkk.

  ---

  • Maybe it would be nice to tidy up your repository and make it minimalist, with just what is necessary, the design folders are still there, as well as the README-template

  ---

  • In addition to coding, keeping your lines clean and easy to understand, showing how organized you are, in technology companies this is very important taking into account that you will work in a time of development, so always try to think about how organized you are (take a look at your read me there on github)!

  ---

  • Your CSS ended up with almost 300 lines which gives the impression that it was a lot of work, maybe you should take a look at your code and analyze if there is any redundancy or if you could do it in a less complicated way, thinking like this, Little by little you will improve your lines of code!

  Anyway, congratulations on your solution, I know that many observations may seem boring, but treat them as sincere help because I spent a while looking hahaha, if I helped you, don't forget to mark my answer as helpful! thank you bro

  Marked as helpful

  1