Newsletter sign-up

Community feedback

• 

  P

  chelsea-here•160

  @chelsea-herePosted about 2 months ago

  Hi there, I only noticed a couple of things. One is kind of big.. the solution does not appear to be responsive to screen size, specifically for smaller screens like mobile. The other smaller item was that the validation warning does not update once you've corrected your input. The validation warning was still apparent and I was able to submit and get the success modal. If you update your "keyup" listener to include validation and styling, rather than just your submit button it should resolve this. Example below:

    email.addEventListener("keyup", function (e) {
      if (validateEmailRegex(e.target.value))
      ) {
        input.classList.add("valid") 
      } else {
        input.classList.add("invalid")}
   });
  

  Other than that, looks good and your button transition is super fun. cheers!

  0