NewsLetter sign-up page | Responsive

Community feedback

• 

  P

  Eli Silk•660

  @elisilkPosted about 2 months ago

  Hi 👋 @shpokas270,

  Congrats on a great solution. 👏 I appreciate the goal of focusing on just getting some experience with the JavaScript logic rather than getting distracted by other aspects of the challenge.

  When you are ready to dive in further 🤿, I'd suggest trying to implement a bit more of the client-side form validation. I found this Client-side form validation guide on MDN to be super helpful as I built my solution to this challenge. And the section on "Validating forms using JavaScript" is especially useful:

  https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation#validating_forms_using_javascript

  For example, right now it looks like your email input field begins with a .wrong-format class on it. I would suggest taking that off and then replacing .wrong-format with the input:invalid selector in your CSS. You then have to make a few more updates to your HTML and to your JavaScript to actually do the validation, but the example provided in the guide is very nicely aligned with this particular challenge, so I hope it will be reasonably straightforward to see the connection. If you run into trouble, though, I'd be happy to help troubleshoot.

  Worth considering if you are thinking about improving on this solution. 🤔

  Happy coding. 💻

  Eli

  Marked as helpful

  0