Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
The
viewportmeta tag is missing. theviewportmeta tag is used to control the layout of the page on mobile devices. Add theviewportmeta tag to the<head>tag:<meta name="viewport" content="width=device-width, initial-scale=1.0">.You can check your solution on a mobile device to see how your solution is distorted by not using this tag. ⚠️
- Use
font-sizeinremoremunits rather than pixels for better responsiveness.
- Images should have an alt attribute. If they don't, some screen readers might read the filename, and "illustration-sign-up-desktop.svg" isn't informative. if the image is purely decorative, you can leave the alt attribute empty.
- The indentation of the code is inconsistent, making it difficult to read and understand. It's recommended to use a code formatter tool, such as Prettier, in your code editor to automatically format your code and maintain consistent indentation.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
1
Danijel• 200
@danijelche
Posted
@MelvinAguilar Thanks for the reply. I will try to fix those errors.
1
