Design comparison
Solution retrospective
My second solution on this site. Comments are welcome.
Community feedback
- @MelvinAguilarPosted 12 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
The
viewport
meta tag is missing. theviewport
meta tag is used to control the layout of the page on mobile devices. Add theviewport
meta tag to the<head>
tag:<meta name="viewport" content="width=device-width, initial-scale=1.0">
.You can check your solution on a mobile device to see how your solution is distorted by not using this tag. โ ๏ธ
- Use
font-size
inrem
orem
units rather than pixels for better responsiveness.
- Images should have an alt attribute. If they don't, some screen readers might read the filename, and "illustration-sign-up-desktop.svg" isn't informative. if the image is purely decorative, you can leave the alt attribute empty.
- The indentation of the code is inconsistent, making it difficult to read and understand. It's recommended to use a code formatter tool, such as Prettier, in your code editor to automatically format your code and maintain consistent indentation.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1@danijelchePosted 12 months ago@MelvinAguilar Thanks for the reply. I will try to fix those errors.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord