Newsletter Sign-Up form with vanila JavaScript validation
Design comparison
Solution retrospective
I'm proud that I managed to find time to complete this challenge. Next time, I'll focus on finishing it more quickly and try to simplify the process to avoid overcomplicating things.
What challenges did you encounter, and how did you overcome them?The biggest challenge was working with validatorjs. Even though I followed the documentation, the code didn’t behave as expected, especially when setting classes in my if statements after validation. So, I decided to skip external libraries and use regex instead, writing my own functions to meet the challenge requirements.
What specific areas of your project would you like help with?I think the main help I need is advice on how to simplify the process and whether my code is broken down enough to be suitable for a Junior role.
Community feedback
- @AdrianoEscarabotePosted 27 days ago
Hey Serhii Orlenko, how’s it going? I was really impressed with your project’s result, though I have some advice that could be helpful:
Consider using
rem
for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.if you want to continue coding with
px
, you can download a very useful extension in vscode, it convertspx
torem
!link -> px to rem
**Everything else looks great. **
Hope this helps! 👍
Marked as helpful0@grifanoPosted 27 days agoHi @AdrianoEscarabote 👋 Thank you for feedback, yes I've been used this technic for my Webflow projects, and I consider to start using it in my next challanges 🙂
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord