Design comparison
Solution retrospective
I am trying to improve my TS and JS skills, please kindly comment on my code.
I am also looking into how to set explicit width and height on the SVG to reduce layout shifts and improve CLS, while making the SVG responsive, please advise the best practice.
Community feedback
- @vgt3j4d4Posted about 1 month ago
-
Does the solution include semantic HTML? Yes
-
Is it accessible, and what improvements could be made? Yes (using aria-live for error notifications)
-
Does the layout look good on a range of screen sizes? Yes
-
Is the code well-structured, readable, and reusable? Yes
-
Does the solution differ considerably from the design? No
-
What specific areas of your project would you like help with?
I am trying to improve my TS and JS skills, please kindly comment on my code. I am also looking into how to set explicit width and height on the SVG to reduce layout shifts and improve CLS, while making the SVG responsive, please advise the best practice.
I find the code OK.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord