Newsletter sign up form with sucess message

Community feedback

• 

  P

  Ehsan Tatasadi•1,780

  @tatasadiPosted about 1 month ago

  Good job on completing this challenge! The structure is solid, and I like how you've handled the form and the success message. Here are a few suggestions to make the code even better:

  • Accessibility: Use h1 as the page title

    • Every page should have an h1 tag, as it's essential for accessibility and SEO. If there isn't a visible one, you can add a hidden h1 using a screen-reader-only class (like sr-only) to improve accessibility for screen readers. It helps users and search engines understand the main focus of the page.
    • In this case, the most logical hidden h1 could be something like "Newsletter Sign-Up." You can keep it visually hidden but readable for screen readers.

  • Use proper button text

    • There's a small typo in the button text: "Subscribe to monthly newletter" should be "Subscribe to monthly newsletter."

  • Form validation

    • You’ve already included a "Valid email required" message, but it could be enhanced with proper ARIA attributes to help screen readers understand the form's error state. For example, using aria-live="polite" on the error message span would announce errors in real-time.

  Keep up the great work! You're almost there, and with these tweaks, the code will be even stronger!

  0