Newsletter sign-up form with success message

Community feedback

• 

  Abdallah Aboelsaoud•220

  @Saoud2021Posted 2 months ago

  Hey there!

  I've taken a look at your newsletter sign-up form code, and I've got to say, it's looking pretty solid! Here are some things I really like about your implementation:

  1. Responsive Design: You've used media queries to adapt the layout for different screen sizes. The <picture> element with different sources for mobile and desktop is a great touch!

  2. Accessibility: Your form is well-structured with appropriate labels and placeholder text.

  3. JavaScript Functionality: The email validation and success message display are implemented nicely. I like how you're toggling classes for showing/hiding elements.

  4. CSS Organization: Your use of CSS variables for colors is great for maintainability.

  5. Reset Styles: Including a CSS reset is a good practice for consistent styling across browsers.

  6. Semantic HTML: You've used semantic tags like <main> and <footer>, which is great for accessibility and SEO.

  ---

  Overall, you've done a fantastic job! The code is clean, well-organized, and follows many best practices. Keep up the great work!

  Marked as helpful

  0
• 

  modiboCamara•40

  @modiboCamaraPosted 2 months ago

  nicely done , the code is very organized and structure.

  I have only one suggestions for you is that you started using relative units when it comes to paddings, margins and font-sizes it will allow better responsiveness.

  Good job.

  0