Skip to content
Submitted 15 days ago

Newsletter sign-up form with success message

Nikolay Toshev•270
@gilotin
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Newsletter sign-up form with success message
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

A simple newsletter sing-up component created with JavaScript, CSS and HTML.

What challenges did you encounter, and how did you overcome them?

I don't like the CSS i've builded in this challenge and will try to improve on it. Have to work on accessability too.

What specific areas of your project would you like help with?

Any critique about the CCS and HTML will be appreciated.

Community feedback

  • KapteynUniverse•2,170
    @KapteynUniversePosted 15 days ago

    Hey Nikolay, nice job.

    At exactly 1024px image changes to mobile image but layout stays at desktop layout. I think changing max-width of the picture to 1023px will fix it. Also i think the image is decorative, so alt text can be empty, same with the check ticks.

    Adding autofocus and autocomplete to input might be better for accesibility.

    I might miss something but looks like you used same styles except border: none; for .button/.subscribe-card__form-button at line 39 and 134

    There is also some for the .wrapper but i don't know about that, changing it might cause issue for the success card.

    Marked as helpful
    1
    Nikolay Toshev•270
    @gilotinPosted 15 days ago

    @KapteynUniverse Thank you for the review . I really appreciate the feedback!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord