Newsletter sign-up form with success message

Community feedback

• 

  jen067•190

  @jen067Posted about 2 months ago

  The code is clean, but there are a few areas that can be improved

  1. Remove height: auto because when I enter the page after a successful authentication, the container's height is insufficient, causing a vertical scrollbar to appear. I tried removing height: auto, and the original layout remains the same without the scrollbar.

  2. When checking for the presence of error messages via the button, you could use add and remove instead of toggle. I believe the error message should persist when the input format is incorrect, but toggle will cause the error message to disappear if I press the button an even number of times, even when the input is still incorrect.

  3. Perhaps you could add code to clear the input fields after a successful validation, instead of keeping the previous data in the fields.

  Marked as helpful

  0
• 

  P

  Nikita Vologdin•470

  @NikitaVologdinPosted about 2 months ago

  @jen067 Jen you have made the best review I ever had. Thank you so much! According to your suggestions:

  1. I decided to add min-height and keep height auto simultaneously. Thank you for noticing the scroll bar. I removed it after your suggestion.
  2. You are right! I refactored these functions. To use toggle was the wrong idea.
  3. I added a clear input field function after your suggestion.

  You have significantly improved my markup. Please let me know if you ever would like to get a review from me on any challenge. Please have a great day =) Best, Nikita

  0