Newsletter Sign-up Form with Success Message

Community feedback

• 

  @valchiz•150

  @yemmighto

  Posted about 1 month ago

  I really love this, checking out what you did, gave me some insight and corrections on what I did, thanks

  00
• 

  ylin320•180

  @ylin320

  Posted about 1 month ago

  The structure is well-organized. Great job! 🎉

  ---

  📌 Email Validation

  Current implementation in signup-form.js:

  isValidEmail(email) {
      const emailRegExp = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;
      return emailRegExp.test(email);
  }
  

  Issues:

  • Too permissive – allows invalid emails like !dsa@dsa.dsa
  • Does not enforce valid TLD length
  • Accepts special characters that shouldn’t be allowed

  ---

  💡 Recommended Fix:

  isValidEmail(email) {
      const emailRegExp = /^[a-zA-Z0-9]+@[a-zA-Z]+\.[a-zA-Z]{2,}$/;
      return emailRegExp.test(email);
  }
  

  • Ensures only valid characters are used
  • Prevents invalid domain formats
  • Enforces a minimum TLD length of 2 characters

  ---

  Overall, this is a well-structured and well-implemented newsletter signup form!Keep up the great work! 🚀

  01