Skip to content
Submitted 11 months ago

Newsletter Sign Up Form With Success Message

hakim taibi•50
@taibihakim2002
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Newsletter sign-up form with success message
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

It is a simple and easy challenge, I didn't face any difficulties But I am not sure about the solution to the application in best practices, If you have any comments about this, let us know Thank you ♥

Community feedback

  • Kimo Spark•2,190
    @kimodev1990Posted 11 months ago

    Really great work in completing the challenge and loved the transition between two containers, Just a simple feedback :

    • If I added space at start or end of the input email ( not in between ), It gives an error. To eliminate this issue , You could just adjust in the javascript :
    e.preventDefault( );
let emailValue = emailInput.value.trim( ) ;

    The rest of your code is okay, trim ( ) removes if there is any spaces added in input.

    Hope you find this Helpful.

    Other than that, Nice work & Keep going on.

    0
    hakim taibi•50
    @taibihakim2002Posted 11 months ago

    It was excellent feedback thank you @kimodev1990

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord