Newsletter Sign Up Form with ReactJS and CSS | Deployment on Vercel

Community feedback

• 

  Ignacio Spreafico•590

  @nachospreaficoPosted over 1 year ago

  Hello Nikhil, hope you are doing great!

  I just wanted to give you my feedback for what I've seen:

  • In your css, you are using media queries to set styles for mobiles up to 375px which is of course great, but when resizing my window the styles apply up to 374px included and not on 375px.
  • I also noticed that you left a console.log to log the width of the viewport when the width changes.
  • To continue with my first point, after 375px and up to around 850px, the layout gets all clogged up. I think you might need to apply styles for devices larger than mobiles but smaller than desktop.
  • I also noticed that you left a console.log to log the width of the viewport when typing in the input.
  • I would also add an error handling in the input for then the user tries to submit multiple blank spaces or just an empty input.

  This is what I've seen at very quick glance. Hope you find it useful.

  Happy coding!

  Marked as helpful

  1

  ---

  

  Nikhil Tanwar•260

  @NikNTPosted over 1 year ago

  @nachospreafico

  First, thanks a lot for taking out the time to review my project.

  Your review and suggestions are highly practical. I can definitely see a scope for improvement - specifically in responsive layouts.

  I will definitely take these into consideration and further improve my code.

  Thanks for supporting me for being a better developer!

  Best,

  Nikhil

  0
• 

  Nikhil Tanwar•260

  @NikNTPosted over 1 year ago

  Hi everyone. I've posted the solution on YouTube.

  Please have a look and don't forget to provide any feedback or criticism. I would appreciate it.

  https://youtu.be/B9T_yjWqZtk

  0