Skip to content
Submitted about 2 months ago

Newsletter Sign-Up Form

Arsh•280
@arsh-de
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Newsletter sign-up form with success message
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I was able to match the styling and was also able to DOM manipulation.

What challenges did you encounter, and how did you overcome them?

I had challenges with design and got confused which class to add or remove. I was bad at naming the class in a way that it would be easy to make sense of them. Finally, I looked at other people solutions and was able fix it.

What specific areas of your project would you like help with?

Naming of classes and can also someone tell how to improve my skills for a job. Recommend me a website for more practice of JS and CSS.

Community feedback

  • Thomas•450
    @TomSifPosted about 2 months ago

    Hello, First of all, congratulations for completing the project, I'm not very well placed to give advice given my current level, but I can share with you a few points that you could improve:

    • Don't forget to add meta description and meta keywords tags for SEO
    • Find out about the BEM method to name your classes in css
    • It is better to use font-face to load and store your fonts, you will find most font-google in woff2 format (lighter) here: https://gwfh.mranftl.com/fonts
    • I invite you to check the modern reset css: https://www.joshwcomeau.com/css/custom-css-reset/
    • you have a small bug on your no repeat background when you switch from the mobile version to desktop.
    • I advise you to always start with the mobile version.
    • I noticed that your success message disappeared on its own without me having to click on the dismiss button, I couldn't understand why

    So I hope these little tips can help you and congratulations again for the quality of your work, keep coding, good luck :)

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord