Newsletter sign up form

Community feedback

• 

  Tonny Blair•270

  @Tonny-Blair-DanielPosted about 2 months ago

  Thanks for the suggested improvements and for the smaller screens it was working but its the Javascript making it not to work as expected. And the email validation was challenging that's I submitted hoping someone would give me a way forward thanks a lot.

  0
• 

  Paradox•330

  @TarestaPosted about 2 months ago

  Hi there, it was a great effort. The style for the bigger screens is almost identical to the design. However, the form, currently, does not provide email validation. I input several wrong address types and they were accepted as well. In your javascript, maybe you can add the functions for such types of situations. As I can see you are using browser in-built email validation, so you do not have to do much. Here is what I can suggest.

  form.addEventListener('submit', () => {
    if (email.validity.valid) {
    //Show the thank you message
  }
  else {
  //Show the error message
  //Prevent the toggling of the screen to reveal the thank you message
  }
  });
  

  Another thing is that the design is currently not working for screens smaller than 768px, so this can be another area that you might look into. Other than that it was a good job. All the best wishes for your future projects.

  0