newsletter sign up form

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Regarding the styles, I would recommend avoiding defined heights and widths, especially using vh or vw, as it can make your component behave unexpectedly. Try using zoom to observe the strange behavior. If you want to limit the width, consider using max-width, and avoid defining a fixed height. Let the content determine the height or use min-height to allow the component to resize on any screen.

  • Add a cursor: pointer to the button for a more intuitive user experience.

  • Consider using a CSS reset to ensure consistent styles across different browsers.

  • Avoid using too many ids; reserve them for JavaScript and use classes for styling in CSS.

  • The width: 100vw is not necessary.

  • Consider using min-height: 100vh instead of height: 100vh to prevent it from getting cut off on mobile devices.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  karan-2004•70

  @karan-2004Posted 11 months ago

  @MelvinAguilar Yeah bro got it. Thank you for your feedback.

  0