@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
Regarding the styles, I would recommend avoiding defined heights and widths, especially using
vh
orvw
, as it can make your component behave unexpectedly. Try using zoom to observe the strange behavior. If you want to limit the width, consider usingmax-width
, and avoid defining a fixed height. Let the content determine the height or usemin-height
to allow the component to resize on any screen. -
Add a
cursor: pointer
to the button for a more intuitive user experience. -
Consider using a CSS reset to ensure consistent styles across different browsers.
-
Avoid using too many ids; reserve them for JavaScript and use classes for styling in CSS.
-
The
width: 100vw
is not necessary. -
Consider using
min-height: 100vh
instead ofheight: 100vh
to prevent it from getting cut off on mobile devices.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@karan-2004
Posted
@MelvinAguilar Yeah bro got it. Thank you for your feedback.