Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

newsletter form

@mahedee007

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

@nachospreafico

Posted

Hello, Maheedee!

Nice job with this challenge. I just want to give my feedback:

  • It seems you only did the challenge for desktop view, as when I try to resize the window the layout breaks.
  • upon submitting an invalid email, the error message disrupts the layout of your form. Also, the input doesn't show the error.
  • After submitting a valid email, the success message appears but in the message, the string "${user.email}" appears instead of the actual user's email.
  • Finally, after clicking the "dismiss message" button, instead of reloading the page, it removes the success message and shows the submission form with the layout broken.

Other than that, it looks good. I haven't had the time to go through your code, but from the UX side, that's what I can see.

Cheers, and happy coding!

Marked as helpful

0

@mahedee007

Posted

Hello @nachospreafico , thank you very much for your valuable feedback. yes, I also know that. and I am working on that to correct all. thanks for your detail observation.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord