Design comparison
SolutionDesign
Community feedback
- @CelianBPosted over 1 year ago
Hi, here is my comments
- Not responsive
- Wrong font
- you function "validateEmail" can be shorcuted by
return (/^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/.test(emailVal))
- you should define your variable email in validateInput function
- you could use variable for colors
- Create the entire div with js in success.html is a bad practice, just create a span with an Id and write in it with .innerText
- Consistency with semi-colons, use Prettier
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord