news-homepage-main

Community feedback

• 

  Nabil Wasir•680

  @NabilWasirPosted almost 2 years ago

  Great work on the desktop version

  You can use <main></main> instead of div/span to remove accessibility issues. And you haven't made the mobile version, If you want help you can visit my solution to this challenge.

  Hopefully, you will find my feedback helpful. If you do find my feedback helpful don't forget to mark this comment helpful!

  Marked as helpful

  0

  ---

  

  Draven•210

  @draven5254Posted almost 2 years ago

  @NabilWasir thank you for the tips appreciated, i have the mobile version i forgot to put the screenshots it's my firstime to use this website but it's in my github repository

  0
• 

  Adriano•38,270

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Draven, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!

  to solve this problem do this:

  <a href="/">Read more</a>

  As this page is a complete page, meaning it has a header, a main section, and a footer, wrap the main content in the main tag so that users who use screen readers can understand what the main content of the screen is. Every HTML document must contain a main tag.

  The remainder is excellent.

  I hope it's useful. 👍

  0