News-homepage

Community feedback

• 

  S MD suleman•3,530

  @sulemaan7070Posted over 1 year ago

  hey 😄zohaib, congratulations on completing the challenge... here are a few tips to make your site better.

  1.For the mobile menu which you gave class name of .navhid you can add the

  @media (max-width: 400px)
  .navhid {
      position: fixed;
  }
  

  so that the mobile menu stays on the screen even when the user scrolls down..

  2.Add an overlay in the background when mobile-menu is opened.. more about the overlay here📚

  3.You can use picture element here which helps you to switch between the images based on the inbuillt media query.. more about picture element here📚

  every thing else looks great, happy coding😄✅👍🏻

  0
• 

  Tobenna•610

  @tobezhanabiPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  I have other recommendations regarding your code that I believe will be of great interest to you. HTML 🏷️:

  The tag <li> needs to be within a <ul> or <ol> so it will not throw an error.

  For a list to be valid, it must have both parent and child elements. Parent elements can either be a set of ul tags or a set of ol tags. Child elements must be declared inside of these tags using the li tag.
  
  Screen readers notify users when they come to a list, and tell them how many items are in a list. Announcing the number of items in a list and the current list item helps listeners know what they are listening to, and what to expect as they listen to it.
  
  If you don't mark up a list using proper semantic markup in a hierarchy, list items cannot inform the listener that they are listening to a list when no parent is indicating the presence of a list and the type of list.
  

  Another issue with your code is the lack of the 'alt' attribute in your img tag do well to fix it I hope you find it helpful ! 😄 Above all, the solution you submitted is great

  Happy coding!

  0