News Website Challenge (HTML 5, CSS3 and JS)

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  Hi Marcus Rangel, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • I noticed that you used px to set a font size, consider using rem for font size .If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user's preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Marcus Rangel•460

  @WebDevCamposPosted about 2 years ago

  @AdrianoEscarabote Hi man! Yes I really should use relative units to typography, and I'll fix that. I really appreciate you bringing it up to my attention tough, it's just it took me hours figuring out grid, which I should know as well. You know, the simple concepts, if not reviewed, are very time consuming. I usually go for px units just because are the basics. Thanks a lot, I will fix this! Kind regards!

  1

  

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  @WebDevCampos happy coding!!

  1

  

  Marcus Rangel•460

  @WebDevCamposPosted about 2 years ago

  @AdrianoEscarabote I loved the extension!!!!!!!! Really cool! I use to do the font-size:62.5% workaround, but this is so much better!

  0

  

  Adriano•38,330

  @AdrianoEscarabotePosted about 2 years ago

  @WebDevCampos glad you liked it ahhahhaha

  0