Design comparison
Solution retrospective
I have some questions on mobile view:
Any suggestion on how to make clickable button to display straight on mobile mode and how to deal with heights and image sizing might be helpful
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi KeerthiVasan-N, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5
- The links must have an aria-label or sr-only text that tells where the link navigates the user. For example: Visit our Facebook. For images, you should set aria-hidden=” true” to be ignored by screen readers and to avoid redundancy and repetition.
The rest is great!
I hope it helps... 👍
Marked as helpful0 - @Chiemeka2006Posted about 2 years ago
@kerrthiVasan-N in ur html u forgot to contain all the <li> tags in a <ul>or <ol> tag. and also the <a> tags should be inside the <li> tags . once u do this u have to go to ur css and on the ul {list-style-type:none; padding:0; margin:0; } Hope this helps ,. <£ <£ <3 :DD
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord