Design comparison
Solution retrospective
Challenge completed in style and with lots of google searched😄. I will be glad to receive any feedback to improve my code. Thanks.✌️
Community feedback
- @BlackpachamamePosted 11 months ago
Hey great solution! although it seems that you have reversed the places of the image and the text for desktop screens. You can fix this easily, you just have to add the
order: inherit
property to yourpicture
(so it stays in place on mobile screens). And also addorder: 1
to your media query so that it changes places on desktop screens. More info:@media screen and (min-width: 800px){ picture { order: 1; } }
Marked as helpful0@rayaattaPosted 11 months agoI'm really happy for your feedback I have improved my code and can I get a bit of advice,using the picture tag has always given me issues should I stick with it or should I stick to using media queries for image swapping@Blackpachamame
0@BlackpachamamePosted 11 months ago@rayaatta It may be a problem that you have a media query with a
min-width: 500px
and in thepicture
you declare it withmedia="(min-width:800px)"
. They should be both 500px or both 800px. Theorder
thing, if you add it with the correct media queries then it would only affect the position of the image.0@rayaattaPosted 11 months agoThanks,I had made it 500 because my laptop was off so I used the phone and adjust Ed the media query. Thanks@Blackpachamame
0@rayaattaPosted 11 months agoThanks,I had made it 500 because my laptop was off so I used the phone and adjust Ed the media query. Thanks@Blackpachamame
0@rayaattaPosted 11 months agoThanks,I had made it 500 because my laptop was off so I used the phone and adjust Ed the media query. Thanks@Blackpachamame
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord