News Homepage with SCSS and JS

Community feedback

• 

  Josue David Lopez Florian•180

  @JUMPSTONIKPosted over 1 year ago

  Greate implementation Gabriel. I reviewed your solution and is pretty good, but I see you have a border in your buttons that dont exist in the design. In case you wanna fix this, you can use the "border" css property and set "none" to remove the border.

  other tip that i could suggest you is to keep the mobile version untile the minimum width be reach to display the desktop version with enough viewport space. This will make you solution a little bit better, because this challenge doesnt have a table version.

  hope this tips be useful for you.

  Marked as helpful

  1

  ---

  

  Gabriel Crispim•430

  @sirbiel100Posted over 1 year ago

  @JUMPSTONIK Hello Josue! Thank you for your feedback, I add a border in fact, but you're right, I think is better follow the original design, I removed it already! About the minimum width, I believe I fixed it thanks to you!

  1

  

  Josue David Lopez Florian•180

  @JUMPSTONIKPosted over 1 year ago

  @sirbiel100 you're welcome and keep coding. :D

  1
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Congrats on completing the challenge successfully! Looks great overall, both on desktop and mobile view.

  It looks like between 600px and 1000px there is some overflow of the content. So you might consider adding a breakpoint for screensizes between 600px and 1000px.

  Hope you find this feedback helpful!

  Marked as helpful

  1

  ---

  

  Gabriel Crispim•430

  @sirbiel100Posted over 1 year ago

  @visualdenniss I appreciate your comment Dennis! I already add an overflow-x between these two widths, thank you!

  1