News homepage with HTML, CSS, Flexbox, Grid, JS

Community feedback

• 

  Hoang Tran•50

  @BeginLearnCodingPosted about 2 years ago

  really nice project! well done bro

  0

  ---

  

  Purbo•330

  @Targitay2012Posted about 2 years ago

  @BeginLearnCoding hello!

  Thanks for the feedback.

  I did my best.

  0
• 

  Alexei•831

  @Batareika007Posted about 2 years ago

  Hi Purbo, The project looks good ! I didn't understand why you put all in header tag but all looks good and responsive, I think you can separate it in header , main and 'footer' create link on your portfolio, but it's up to you. Great work !

  0

  ---

  

  Purbo•330

  @Targitay2012Posted about 2 years ago

  @Batareika007 Hi Aleksey!

  This is the first page, so this is the header and can also contain a menu. At least that's what I understood from the course I took)

  About the footer with links to my profile, you are right, they should be left next time)

  1

  

  Alexei•831

  @Batareika007Posted about 2 years ago

  @Targitay2012

  Usually header contains a company logo, navigation links, search, and maybe contact icons. I never see a whole page was under header tag, maybe it's something new that I missed ? =)

  1

  

  Purbo•330

  @Targitay2012Posted about 2 years ago

  @Batareika007

  I watched how this task was done by the guys with the top rating. You're right, none of them did what I did). On the other hand, the HTML validator didn't throw an error.

  On the course, when we built out landing pages, the teacher always wrapped the first screen in a header tag, which included a logo, a menu, and the first screen, which was usually a slider. Therefore, here, out of habit, I wrapped everything in a header). You're right, I shouldn't have wrapped everything in a header tag.

  1

  

  Alexei•831

  @Batareika007Posted about 2 years ago

  @Targitay2012

  You did a good job for searching/ researching on this topic and learn how to do better markup, keep going you on right path =)

  1