News Homepage with CSS Grid and @media

Community feedback

• 

  Petabyte•190

  @peta-8-bitPosted almost 2 years ago

  Congratulations @AbibGuardian50 for completing you first Junior level challenge 🎉🎉

  I am also fairly new to web development, but here are my two cents:

  • I would recommend having the logo and navbar out of the main grid since they go on one line only.
  • The responsive layout works alright, however the navigation items cant be seen, the main picture can be replaced with the square picture.The layout needs to be centered in both desktop and mobile version.
  • Kudos on incorporating semantic tags like main and section. My only recommendation is the right-content and bottom-content can be wrapped in the section tag and the individual articles inside article tag.

  I know it sounds like so much work, but when i did this challenge i took 1 full day just trying to figure out the navbar. I don't even want to talk about the entire challenge, but it gets waaayyy easier after doing it right one time.

  Happy Coding╰(°▽°)╯

  Marked as helpful

  0

  ---

  

  Abieb_Guardian•200

  @AbibGuardian50Posted almost 2 years ago

  @peta-8-bit Thanks for your feedback,this is helpful and make great improvement for my next challenge Have a great day!

  0