Responsive news homepage using grid layout, flex box and javascript

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The header ⚠️ should be outside the main element for improved semantics.

  • The way your navbar was created is incorrect ❌. There should only be one nav and you will use CSS to make the changes for the mobile and desktop layout.

  • ⚠️ The logo should be outside the nav and the logo’s alt tag description needs to be improved upon ⚠️; it should state the company’s name.

  • The nag toggle should be built ⚠️ using a button to be accessible. It should also have an aria-expanded which you will use to open and close in JS and a aria-label for screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0

  ---

  

  Matheus Dumont•390

  @Dumont19Posted almost 2 years ago

  @vcarames Thank you for your comment. I'll check all the points and improve my solution.

  0