Submitted almost 2 years ago
Responsive news homepage using grid layout, flex box and javascript
@Dumont19
Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The
header
⚠️ should be outside themain
element for improved semantics.
- The way your navbar was created is incorrect ❌. There should only be one
nav
and you will use CSS to make the changes for the mobile and desktop layout.
- ⚠️ The logo should be outside the
nav
and the logo’salt tag
description needs to be improved upon ⚠️; it should state the company’s name.
- The nag toggle should be built ⚠️ using a
button
to be accessible. It should also have anaria-expanded
which you will use to open and close in JS and aaria-label
for screen readers.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0@Dumont19Posted almost 2 years ago@vcarames Thank you for your comment. I'll check all the points and improve my solution.
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord