News Homepage Using HTML5 , CSS3 , JavaScript and Bootstrap5

Community feedback

• 

  Dusan Brankov•860

  @dusan-bPosted about 2 years ago

  Hey Milos,

  I like your solution and the correctly applied HTML structure.

  To improve accessibility, though, you should avoid using the <div> element for semantic elements, such as buttons. To make the menu button accessible for keyboard and screen reader users, you should use the <button> element instead .

  In addition, the alternative text of the menu icon should describe the purpose of the menu button, i.e. something like "main menu" would be more precise, as screen readers would then read the button as "main menu, button".

  You should also place the menu button right after the opening <nav> tag so that users can recognise it more easily.

  Here's a simplified example:

  <nav>
    <button>
      <img src="" alt="main menu">
    </button>
    <ul>
      ...
    </ul>
  </nav>
  

  The rest looks pretty good. Keep going, and happy coding. :)

  Marked as helpful

  0