news homepage

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted over 1 year ago

  Hey there! 👋 Here are some recommendations for enhancing your code:

  This challenge still needs A LOT of work ⚠️ to be considered complete. I suggest you continue working on the easier challenges first, get feedback and work your way up.

  • Unless your company requires⚠️ you to use a library/framework, I strongly suggest you stay away ❌ from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library/framework, you are robbing yourself from actually learning how to code.

  • This <section id="section1"> should be a header element ⚠️.

  • The logo should be outside ⚠️ the nav and why did you lottery write the letter W? Never do that unless the clients says so. The project files include the logo file. Once you fix this make sure to include an alt tag.

  • Every site should ALWAYS have ✅ a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it you will wrap everything outside the header element ⚠️.

  More Info: 📚

  MDN Main Element

  • The main article (The Bright Future of Web 3.0) should be wrapped ⚠️ inside an article element.

  • The main article requires the use of two illustrations 🎑 at different breakpoints ⚠️. The picture element will facilitate this.

  Here is how it looks like implemented: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • The "The Bright Future of Web 3.0?" Is not an h1 heading ❌, it is another article heading. It should be an h2 heading ✅ and there should be a visibly hidden h1 in the site.

  • The "Read More" button was created with the incorrect element ❌. When users click on the button they should directed to a different part of your site; the anchor element will allow this to happen.

  More Info:📚

  MDN The Anchor element

  • Avoid skipping heading levels ⚠️. Always start with the h1 (which can only be used once) and you will go down the hierarchy level depending on the heading’s level of importance.

  • The "new" section should be built using an unordered list element ⚠️ and have an aria-label.

  • The bottom section should be built ⚠️ using an ordered list and have a visually hidden h2 heading.

  • Numbers are never ❌ headings.

  • The elements that are meant to be interactive are not⚠️. I suggest looking at the "active-states" design file to see which elements are meant to be interactive so that they can be built using the anchor element.

  More Info:📚

  MDN The Anchor element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 👾

  0

  ---

  

  harshitkandpal•40

  @harshitkandpalPosted over 1 year ago

  @vcarames thanks for your support 👍

  0