Design comparison
Solution retrospective
I'm really proud of the sidebar that I did in mobile layout. It can be made better but this is the best I could do.
What challenges did you encounter, and how did you overcome them?Definitely the biggest challenge I faced was to create a desktop layout after the mobile layout. I was able to complete I would say like 70% but the other 30% is really not there.
What specific areas of your project would you like help with?I would really like some help in my desktop layout. How I can further improve it to make it look more close to the design as possible.
Please, feel free to look at my code, fork it, make some changes and push it to your fork. I would love to see where I went wrong and where I can improve.
Community feedback
- @AdrianoEscarabotePosted 4 months ago
Hi Mukarram Haq, hope you're doing well! I loved how your project turned out, but I’ve got a few suggestions that could be useful:
I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written
Read More, he is not confirming a form, or something like, it will be redirected to another page, to Read More about!to solve this problem do this:
<a href="/">Read More</a>The rest is fantastic.
Hopefully, you'll find it helpful. 👍
Marked as helpful1P@MukarramHaqPosted 4 months ago@AdrianoEscarabote Hello, thank you for the awesome feedback.
That actually makes sense. I was confused between whether I should be using a button or a link but your explanation made it clear.
Also, do you have any suggestion as to how to get everything aligned in the desktop layout? I have been struggling with that the most.
0 - @dylan-dot-cPosted 4 months ago
Hey! Well done on this challenge, I do see a few parts where you missed out on and I would love to fork and contribute to your solution!
I completed mine with react(if I remember correctly) but I would still like to help you improve and make it better.
One thing tho is that if we are trying to make it precise to the design, it would be nice to also have the figma design if you don't mind(and it doesn't violates FEM's rules) it could help getting a closer design if thats what you need.
Anyways I would probably look at your code sometime next week as this weekend is busy for me as usual!
Take care!
Marked as helpful1P@MukarramHaqPosted 4 months ago@dylan-dot-c Thank you for taking your time out and looking at my solution. Yes, I do have the Figma file. I think the problem that I am running into is the layout of the desktop.
I just am not able to align them properly
Yes, ofc whenever you have time.
I really appreciate the help!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord