Skip to content
Submitted almost 2 years ago

News Homepage Main flex

Franci Melink•400
@francimelink
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...News homepage
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Hi,

After a log time I decied to practice CSS again. Please write some comments about my solution.

I will be very happy for any commenters. Especially those from whom I can learn something extra

Community feedback

  • Sinisa Vukmirovic•1,690
    @SinisaVukmirovicPosted almost 2 years ago

    Hello!

    Quality code, nice use of semantic html5 elements.

    You just missed an opportunity to use footer element for that div.attribution at the end.

    That would fix that one error in your report. no <div> should be directly inside of <body> element. This - "All page content should be contained by landmarks" means just that. Landmark means semantic element. All elements should be contained inside semantic elements.

    Try it, it should remove that one error. Other than that, more that solid looking code, use of BEM methodology for class names and nice project folder structure, in my opinion.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord