News homepage

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • This LINK needs to be a button ⚠️ since currently it is not accessible.

  • The button should also have ⚠️ an aria-label, aria-control and a aria-expanded.

  • The company logo should be outside ⚠️ the nav and its alt-tag description should state the company's name; in this case, "W News"

  • This LINK should be ⚠️ an article element and not a section.

  • The headings in your site are being used incorrectly❌. Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. For this challenge, it is actually visually hidden.

  • The "The Bright Future of Web 3.0?" Is **not an **h1 heading ❌, it is another article heading. It should be an h2 heading ✅ and there should be a visibly hidden h1 in the site.

  • Numbers are never ❌ headings.

  • Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The anchor tag will achieve this.

  More Info:📚

  MDN The Anchor element

  • The “image” in this component are purely decorative⚠️. Their alt tag should be left blank to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  These are just a few of the things that needs correction. There are still a lot more things that need fixing...

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 👾

  Marked as helpful

  1

  ---

  

  MerMory-Alloc•250

  @MerMory-AllocPosted almost 2 years ago

  Hi @vcarames thanks for the feedback, really helpful and insightful information here that made me rethink about the importance of the accessibility.

  I did update my code depending one this feedback and i just want to ask and to know why you see that the first section should be an article? because i just see it as a section that contains just a presentation of an article and does not contain an actual article.I don't know maybe i am wrong i just want a lit bit of guidance here. Thanks

  also you said that there are other things that needs fixing , I will be happy to point me to them. and Thanks again

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @MerMory-Alloc

  Glad I could help!

  The section element is used to define a group of related content and this just one single article… so it make no sense to wrap the entire thing in a section element.

  Not only that it checks off all the requirements for the article element; make sense on its own and be independently distributable (can be used in on another site).

  Hope this clear things up.

  Marked as helpful

  1

  

  MerMory-Alloc•250

  @MerMory-AllocPosted almost 2 years ago

  @vcarames Thanks you really made it clear for me.

  0