Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

News homepage CSS Flex & Grid, JS

Kacper 180

@kacper-reiman

Desktop design screenshot for the News homepage coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


First challenge done using javascript. Probably it could've been done better, simplier way.. but whatever - I'm just excited about my first ever working script written without anybodys help. Any feedback or advice would be welcome.

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi Kacper, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!

to solve this problem do this:

<a href="/" id="read__more">Read more</a>

If we see how the layout is behaving at higher resolutions, with the help of google dev tools, we will see that it is stretching a lot, to solve this we can use a max-width with the value we want the content to stop growing and to center use a margin: 0 auto;

body {
    max-width: 1440px;
    margin: 0 auto;
}

The rest is great!

I hope it helps... 👍

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord