Submitted almost 2 years ago
News homepage challenge. Grid, Flexbox and JS
@Wesley-Martins
Design comparison
SolutionDesign
Solution retrospective
If anyone has any tips or observations, i would appreciate. That's it.
Community feedback
- @arrKhange1Posted almost 2 years ago
Hi, nice solution!
Here what I’ve spotted:
<div class="news-section__title__container">
BEM says that element can’t have another element in it. In your situation title is already an element of news section, so it can’t be a block for container.
The solution might be to put a hyphen after title instead of double underscore
Marked as helpful0@Wesley-MartinsPosted almost 2 years ago@arrKhange1 I were a bit unsure about that class, thanks man!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord