P
Srijan Manandhar• 450
@srijanss
Posted
- header landmark is used properly with nav and links within it, however the nav content is duplicated for desktop and mobile view. You can use CSS to make one nav content work for both mobile and desktop
- main element is used for the content, however the headings are not used properly. heading order goes from h2 to h4
- rather than using div for the content , you can look for section or article landmark element. These elements are accessibility friendly and gives purpose for the wrapped content
- layout looks good on all the screen sizes
- code is well-structured, readable and reusable
- solution differs a bit from the design, like the menu drawer in mobile devices is not full height, on large desktop screen content spans full width. With minor changes you can make your solution match the design
0
