Attempt #2, desktop only

Community feedback

• 

  Adriano•38,330

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Samuel To, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!

  to solve this problem do this:

  <a href="/">READ MORE</a>

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  The remainder is excellent.

  I hope it's useful. 👍

  Marked as helpful

  0

  ---

  

  Samuel To•70

  @KarrimorRiflePosted almost 2 years ago

  @AdrianoEscarabote thanks for the advice, I will likely use rem more on personal projects, but whilst working with front end mentor I'll likely still be using px due to the fact i want to get it as close as possible (moving forward from here). And yes the anchor tag would've been a better option there, thanks for pointing it out!

  0